On Sun, 2017-09-10 at 12:33 +0100, Tomasz Kramkowski wrote: > On Sat, Sep 09, 2017 at 10:47:14PM +0100, Ben Hutchings wrote: > > 3.16.48-rc1 review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Tomasz Kramkowski <tk@xxxxxxxxxx> > > > > commit 9547837bdccb4af127528b36a73377150658b4ac upstream. > > > > The (1292:4745) Innomedia INNEX GENESIS/ATARI adapter needs > > HID_QUIRK_MULTI_INPUT to split the device up into two controllers > > instead of inputs from both being merged into one. > > > > Signed-off-by: Tomasz Kramkowski <tk@xxxxxxxxxx> > > Acked-By: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> > > Signed-off-by: Jiri Kosina <jkosina@xxxxxxx> > > [bwh: Backported to 3.16: adjust context] > > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx> > > ---- snip ---- > > Hi, > > Unfortunately this quirk will not make the device mentioned in the commit > work on its own. > > This fix was an additional fix on top of another more fundamental fix > which made the device, and others like it, operational. OK, I'm dropping this now and will consider adding the complete set of fixes in a later update. Perhaps you could send this list as a new message to stable@xxxxxxxxxxxxxxx if you're interested in adding support for this device to stable branches. Ben. > This fix was included in commit: > > Valtteri Heikkilä (1): > HID: reject input outside logical range only if null state is set > [3f3752705dbd50b66b66ad7b4d54fe33d2f746ed] > > This patch does not appear in your shortlog for this submission and it > doesn't appear when I search linux-stable as of v3.16.47. > > Additionally, the following patch might also be helpful in ensuring > the correct operation of the aforementioned device (and other devices > like it): > > Tomasz Kramkowski (1): > HID: clamp input to logical range if no null state > [c3883fe06488a483658ba5d849b70e49bee15e7c] > > However, if the above patches are not appropriate for backporting > to stable then I have absolutely nothing against my patch not being > backported either. My patch alone will not make the device operate in > a useful manner. > > Thank you for considering my patch for the 3.16 stable tree and have a > nice day, > -- Ben Hutchings Kids! Bringing about Armageddon can be dangerous. Do not attempt it in your own home. - Terry Pratchett and Neil Gaiman, `Good Omens'
Attachment:
signature.asc
Description: This is a digitally signed message part