Re:[failures]mm-dmapool-align-to-arch_dma_minalign-in-non-coherent-dma-mode.patchremoved from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Which kind of failure? Build failures are fixed in V3 by the 1st patch in this series.

Huacai
 
------------------ Original ------------------
From:  "akpm"<akpm@xxxxxxxxxxxxxxxxxxxx>;
Date:  Thu, Sep 14, 2017 07:55 AM
To:  "chenhc"<chenhc@xxxxxxxxxx>; "stable"<stable@xxxxxxxxxxxxxxx>; "zhangfx"<zhangfx@xxxxxxxxxx>; "mm-commits"<mm-commits@xxxxxxxxxxxxxxx>; 

Subject:  [failures]mm-dmapool-align-to-arch_dma_minalign-in-non-coherent-dma-mode.patchremoved from -mm tree

 

The patch titled
     Subject: mm/dmapool.c: align to ARCH_DMA_MINALIGN in non-coherent DMA mode
has been removed from the -mm tree.  Its filename was
     mm-dmapool-align-to-arch_dma_minalign-in-non-coherent-dma-mode.patch

This patch was dropped because it had testing failures

------------------------------------------------------
From: Huacai Chen <chenhc@xxxxxxxxxx>
Subject: mm/dmapool.c: align to ARCH_DMA_MINALIGN in non-coherent DMA mode

In non-coherent DMA mode, kernel uses cache flushing operations to
maintain I/O coherency, so the dmapool objects should be aligned to
ARCH_DMA_MINALIGN.

Link: http://lkml.kernel.org/r/1505294451-21312-1-git-send-email-chenhc@xxxxxxxxxx
Signed-off-by: Huacai Chen <chenhc@xxxxxxxxxx>
Cc: Fuxin Zhang <zhangfx@xxxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 mm/dmapool.c |    3 +++
 1 file changed, 3 insertions(+)

diff -puN mm/dmapool.c~mm-dmapool-align-to-arch_dma_minalign-in-non-coherent-dma-mode mm/dmapool.c
--- a/mm/dmapool.c~mm-dmapool-align-to-arch_dma_minalign-in-non-coherent-dma-mode
+++ a/mm/dmapool.c
@@ -140,6 +140,9 @@ struct dma_pool *dma_pool_create(const c
 	else if (align & (align - 1))
 		return NULL;
 
+	if (!plat_device_is_coherent(dev))
+		align = max_t(size_t, align, dma_get_cache_alignment());
+
 	if (size == 0)
 		return NULL;
 	else if (size < 4)
_

Patches currently in -mm which might be from chenhc@xxxxxxxxxx are




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]