IB/addr: Fix setting source address in addr6_resolve()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

The commit eea40b8f624f25 has introduced a bug in rdma/core which broke iw_cxgb4/ipv6. 

So, please pull the below commit to 4.9.x, 4.11.x stable release as it fixes the issue.

commit 79e25959403e6a79552db28a87abed34de32a1df
Author: Roland Dreier <roland@xxxxxxxxxxxxxxx>
Date:   Tue Jun 6 09:22:00 2017 -0700

    IB/addr: Fix setting source address in addr6_resolve()

    Commit eea40b8f624f ("infiniband: call ipv6 route lookup via the stub
    interface") introduced a regression in address resolution when connecting
    to IPv6 destination addresses.  The old code called ip6_route_output(),
    while the new code calls ipv6_stub->ipv6_dst_lookup().  The two are almost
    the same, except that ipv6_dst_lookup() also calls ip6_route_get_saddr()
    if the source address is in6addr_any.

    This means that the test of ipv6_addr_any(&fl6.saddr) now never succeeds,
    and so we never copy the source address out.  This ends up causing
    rdma_resolve_addr() to fail, because without a resolved source address,
    cma_acquire_dev() will fail to find an RDMA device to use.  For me, this
    causes connecting to an NVMe over Fabrics target via RoCE / IPv6 to fail.

    Fix this by copying out fl6.saddr if ipv6_addr_any() is true for the original
    source address passed into addr6_resolve().  We can drop our call to
    ipv6_dev_get_saddr() because ipv6_dst_lookup() already does that work.

    Fixes: eea40b8f624 ("infiniband: call ipv6 route lookup via the stub interface")
    Cc: <stable@xxxxxxxxxxxxxxx> # 3.12+
    Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx>
    Acked-by: Paolo Abeni <pabeni@xxxxxxxxxx>
    Signed-off-by: Doug Ledford mailto:dledford@xxxxxxxxxx


Thanks,
Raju 





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]