Re: [PATCH] nvme: fix lightnvm check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 06, 2017 at 11:48:25AM +0200, Christoph Hellwig wrote:
> nvme_nvm_ns_supported assumes every device is a pci_dev, which leads to
> reading an incorrect field, or possible even a dereference of unallocated
> memory for fabrics controllers.
> 
> Fix this by introducing a quirk for lighnvm capable devices instead.

Ugh, even with this quirk, new lightnvm device will be broken for
all existing kernels. This sort of thing really could benefit from a
standard's defined capability or command set supported bit to distinguish
lightnvm devices. Lacking that, this looks like the only thing we can
do at the moment.

Reviewed-by: Keith Busch <keith.busch@xxxxxxxxx>



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]