Patch "drm/i915: fix compiler warning in drivers/gpu/drm/i915/intel_uncore.c" has been added to the 4.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    drm/i915: fix compiler warning in drivers/gpu/drm/i915/intel_uncore.c

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     drm-i915-fix-compiler-warning-in-drivers-gpu-drm-i915-intel_uncore.c.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.


>From foo@baz Thu Aug 31 08:30:43 CEST 2017
Date: Thu, 31 Aug 2017 08:30:43 +0200
To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Subject: drm/i915: fix compiler warning in drivers/gpu/drm/i915/intel_uncore.c

From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

When building with gcc-7, the following warning happens:

drivers/gpu/drm/i915/intel_uncore.c: In function ‘hsw_unclaimed_reg_detect’:
drivers/gpu/drm/i915/intel_uncore.c:638:36: warning: decrement of a boolean expression [-Wbool-operation]
   i915.mmio_debug = mmio_debug_once--;
                                    ^~

As it's really not wise to -- on a boolean value.

Commit 7571494004d8 ("drm/i915: Do one shot unclaimed mmio detection
less frequently") which showed up in 4.6-rc1 does solve this issue, by
rewriting the mmio detection logic, but that isn't really good to
backport to 4.4-stable, so just fix up the obvious logic here to do the
right thing.

Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Paulo Zanoni <przanoni@xxxxxxxxx>
Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
 drivers/gpu/drm/i915/intel_uncore.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -635,7 +635,8 @@ hsw_unclaimed_reg_detect(struct drm_i915
 			  "enabling oneshot unclaimed register reporting. "
 			  "Please use i915.mmio_debug=N for more information.\n");
 		__raw_i915_write32(dev_priv, FPGA_DBG, FPGA_DBG_RM_NOCLAIM);
-		i915.mmio_debug = mmio_debug_once--;
+		i915.mmio_debug = mmio_debug_once;
+		mmio_debug_once = false;
 	}
 }
 


Patches currently in stable-queue which might be from gregkh@xxxxxxxxxxxxxxxxxxx are

queue-4.4/scsi-sg-protect-accesses-to-reserved-page-array.patch
queue-4.4/drm-i915-fix-compiler-warning-in-drivers-gpu-drm-i915-intel_uncore.c.patch
queue-4.4/lpfc-fix-device-discovery-failures-during-switch-reboot-test.patch
queue-4.4/p54-memset-0-whole-array.patch
queue-4.4/btrfs-remove-duplicate-const-specifier.patch
queue-4.4/alsa-au88x0-fix-zero-clear-of-stream-resources.patch
queue-4.4/x86-io-add-memory-clobber-to-insb-insw-insl-outsb-outsw-outsl.patch
queue-4.4/gcov-add-support-for-gcc-version-6.patch
queue-4.4/gcov-support-gcc-7.1.patch
queue-4.4/arm64-fpsimd-prevent-registers-leaking-across-exec.patch
queue-4.4/scsi-isci-avoid-array-subscript-warning.patch
queue-4.4/lightnvm-initialize-ppa_addr-in-dev_to_generic_addr.patch
queue-4.4/arm64-mm-abort-uaccess-retries-upon-fatal-signal.patch
queue-4.4/i2c-jz4780-drop-superfluous-init.patch
queue-4.4/scsi-sg-reset-res_in_use-after-unlinking-reserved-array.patch



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]