Re: [PATCH 4.4.y] drm: rcar-du: Fix crash in encoder failure error path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 16, 2017 at 03:53:48PM +0700, Nhan Nguyen wrote:
> From: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> 
> commit 05ee29e94acf0d4b3998c3f93374952de8f90176 upstream.
> 
> When an encoder fails to initialize the driver prints an error message
> to the kernel log. The message contains the name of the encoder's DT
> node, which is NULL for internal encoders. Use the of_node_full_name()
> macro to avoid dereferencing a NULL pointer, print the output number to
> add more context to the error, and make sure we still own a reference to
> the encoder's DT node by delaying the of_node_put() call.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> Reviewed-by: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx>
> Signed-off-by: Thong Ho <thong.ho.px@xxxxxxxxxxxxxxx>
> Signed-off-by: Nhan Nguyen <nhan.nguyen.yb@xxxxxxxxxxx>
> ---
>  drivers/gpu/drm/rcar-du/rcar_du_kms.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

I also added this to 4.9-stable.



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]