Re: [PATCH v2] mmc: mmc: correct the logic for setting HS400ES signal voltage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8 August 2017 at 12:54, Haibo Chen <haibo.chen@xxxxxxx> wrote:
> Change the default err value to -EINVAL, make sure the card only
> has type EXT_CSD_CARD_TYPE_HS400_1_8V also do the signal voltage
> setting when select hs400es mode.
>
> Fixes: commit 1720d3545b77 ("mmc: core: switch to 1V8 or 1V2 for hs400es mode")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx>

Thanks, applied for fixes!

Kind regards
Uffe

> ---
>  drivers/mmc/core/mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 30a13f0..83d9468 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1289,7 +1289,7 @@ int mmc_hs400_to_hs200(struct mmc_card *card)
>  static int mmc_select_hs400es(struct mmc_card *card)
>  {
>         struct mmc_host *host = card->host;
> -       int err = 0;
> +       int err = -EINVAL;
>         u8 val;
>
>         if (!(host->caps & MMC_CAP_8_BIT_DATA)) {
> --
> 1.9.1
>



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]