On 08/16/2013 05:18 PM, Toralf Förster wrote:
Peter,
I'm observing an erratic behaviour of the stable kernel series 3.10.X resulting in a broken s2disk.
What are the symptoms of the "erratic behavior" and "broken s2disk"?
After few more or less frustrating attempts to bisect that issue I lowered the "bad commit limit" to yours.
Now I'm wondering if your commit could have as a side effect a broken s2disk at a ThinkPad T420
which is booted by an 32 bit stable Gentoo Linux from an external USB and have a running X11 server ? :
Seems unlikely. What is the last "good" 3.10?
Can you attach your bisect log?
Regards,
Peter Hurley
commit e0896b461ff2761c7a36d223f33d4f6d52c7340f
Author: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx>
Date: Sat Jun 15 09:01:00 2013 -0400
tty: Reset itty for other pty
commit 64e377dcd7d75c241d614458e9619d3445de44ef upstream.
Commit 19ffd68f816878aed456d5e87697f43bd9e3bd2b
('pty: Remove redundant itty reset') introduced a regression
whereby the other pty's linkage is not cleared on teardown.
This triggers a false positive diagnostic in testing.
Properly reset the itty linkage.
Signed-off-by: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 6464029..4476682 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -1618,6 +1618,8 @@ static void release_tty(struct tty_struct *tty, int idx)
tty_free_termios(tty);
tty_driver_remove_tty(tty->driver, tty);
tty->port->itty = NULL;
+ if (tty->link)
+ tty->link->port->itty = NULL;
cancel_work_sync(&tty->port->buf.work);
if (tty->link)
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html