On Tue, 11 Jul 2017, James Hogan wrote:
> On Sat, Jul 08, 2017 at 11:24:44PM +0100, Maciej W. Rozycki wrote:
> > Cc: stable@xxxxxxxxxxxxxxx # 3.19+
> > Fixes: 515a6393dbac ("MIPS: kernel: proc: Add MIPS R6 support to /proc/cpuinfo")
>
> That commit landed in v4.0-rc1, not 3.19.
Hmm:
$ git show 515a6393dbac:Makefile | head -5
VERSION = 3
PATCHLEVEL = 19
SUBLEVEL = 0
EXTRAVERSION = -rc4
NAME = Diseased Newt
$
I just trusted that.
> Most stable tags with comments also have square brackets around the
> email too, i.e.:
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.0+
>
> (though maybe thats just not to confuse git-send-email).
It doesn't seem so obvious, it looks fairly random to me. If you say
it helps, then I can adjust -- any pointers to a previous discussion?
> Otherwise:
> Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx>
>
> Nice catch!
Thanks for your review. I actually spotted it visually in the course
of the recent Octeon ISA level discussion, before verifying the fix with
actual hardware.
Maciej