Re: [PATCH 05/19] bcache: fix calling ida_simple_remove() with incorrect minor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 05/19] bcache: fix calling ida_simple_remove() with incorrect minor
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 5 Jul 2017 11:26:45 -0700
Cc: linux-block@xxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, hch@xxxxxxxxxxxxx, axboe@xxxxxxxxx, Tang Junhui <tang.junhui@xxxxxxxxxx>, stable@xxxxxxxxxxxxxxx, Stefan Bader <stefan.bader@xxxxxxxxxxxxx>
In-reply-to: <1498855388-16990-5-git-send-email-bcache@lists.ewheeler.net>
User-agent: Mutt/1.8.0 (2017-02-23)

> +#define BCACHE_TO_IDA_MINORS(first_minor) ((first_minor) >> BCACHE_MINORS_BITS)
> +#define IDA_TO_BCACHE_MINORS(minor)       ((minor) << BCACHE_MINORS_BITS)

Please use inline functions and lower case for these.

References:
- Re: [PULL] bcache fixes and updates for-4.13
  - From: Christoph Hellwig
- [PATCH 01/19] bcache: Fix leak of bdev reference
  - From: bcache

Prev by Date: Re: [PATCH 03/19] bcache: do not subtract sectors_to_gc for bypassed IO
Next by Date: Re: [PATCH 06/19] bcache: explicitly destory mutex while exiting
Previous by thread: Re: [PATCH 01/19] bcache: Fix leak of bdev reference
Next by thread: Re: [PULL] bcache updates based on git.kernel.dk/linux-block:for-next
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Development Newbies] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite Hiking] [Linux Kernel] [Linux SCSI]