This is a note to let you know that I've just added the patch titled
net: don't call strlen on non-terminated string in dev_set_alias()
to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-don-t-call-strlen-on-non-terminated-string-in-dev_set_alias.patch
and it can be found in the queue-3.18 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From foo@baz Thu Jun 29 19:45:34 CEST 2017
From: Alexander Potapenko <glider@xxxxxxxxxx>
Date: Tue, 6 Jun 2017 15:56:54 +0200
Subject: net: don't call strlen on non-terminated string in dev_set_alias()
From: Alexander Potapenko <glider@xxxxxxxxxx>
[ Upstream commit c28294b941232931fbd714099798eb7aa7e865d7 ]
KMSAN reported a use of uninitialized memory in dev_set_alias(),
which was caused by calling strlcpy() (which in turn called strlen())
on the user-supplied non-terminated string.
Signed-off-by: Alexander Potapenko <glider@xxxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
net/core/dev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1194,8 +1194,9 @@ int dev_set_alias(struct net_device *dev
if (!new_ifalias)
return -ENOMEM;
dev->ifalias = new_ifalias;
+ memcpy(dev->ifalias, alias, len);
+ dev->ifalias[len] = 0;
- strlcpy(dev->ifalias, alias, len+1);
return len;
}
Patches currently in stable-queue which might be from glider@xxxxxxxxxx are
queue-3.18/net-don-t-call-strlen-on-non-terminated-string-in-dev_set_alias.patch