Re: [PATCH] thermal: qcom: tsens: fix crash due to incorrect __init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri 30 Jun 13:40 PDT 2017, Rob Clark wrote:

> init_common() is called from probe, which can happen after the __init
> section is already unloaded in the case of -EPROBE_DEFER.  Causing a
> later probe to attempt to branch to hyperspace.
> 
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Rob Clark <robdclark@xxxxxxxxx>

Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Regards,
Bjorn

> ---
>  drivers/thermal/qcom/tsens-common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> index b1449ad..22ad37c 100644
> --- a/drivers/thermal/qcom/tsens-common.c
> +++ b/drivers/thermal/qcom/tsens-common.c
> @@ -123,7 +123,7 @@ static const struct regmap_config tsens_config = {
>  	.reg_stride	= 4,
>  };
>  
> -int __init init_common(struct tsens_device *tmdev)
> +int init_common(struct tsens_device *tmdev)
>  {
>  	void __iomem *base;
>  
> -- 
> 2.9.4
> 



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]