RE: [PATCH] vmbus: re-enable tasklet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@xxxxxxxxxxxxxxxxxx]
> Sent: Thursday, June 29, 2017 4:31 PM
> To: KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyan Yang
> <haiyang@xxxxxxxxxxxxx>
> Cc: devel@xxxxxxxxxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx; Greg KH
> <greg@xxxxxxxxx>
> Subject: Re: [PATCH] vmbus: re-enable tasklet
> 
> On Thu, 22 Jun 2017 16:16:54 -0700
> Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx> wrote:
> 
> > This problem shows up in 4.11 when netvsc driver is removed and
> reloaded.
> > The problem is that the channel is closed during module removal and the
> > tasklet for processing responses is disabled. When module is reloaded
> > the channel is reopened but the tasklet is marked as disabled.
> >
> > Patch for upstream is pending, but less urgent since problem doesn't
> > happen with network driver in 4.12.
> >
> > Signed-off-by: Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>
> > ---
> >  drivers/hv/channel.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
> > index 321b8833fa6f..36c9ce191b74 100644
> > --- a/drivers/hv/channel.c
> > +++ b/drivers/hv/channel.c
> > @@ -606,6 +606,8 @@ static int vmbus_close_internal(struct
> vmbus_channel *channel)
> >  		get_order(channel->ringbuffer_pagecount * PAGE_SIZE));
> >
> >  out:
> > +	/* re-enable tasklet for use on re-open */
> > +	tasklet_enable(&channel->callback_event);
> >  	return ret;
> >  }
> >
> 
> Ping.
> 
> What is the state of this patch? Why is it not queued for 4.11 stable?

I will submit this shortly.

K. Y




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]