On 06/29/2017 01:46, James Hogan wrote: > On 29 June 2017 02:33:28 BST, Huacai Chen <chenhc@xxxxxxxxxx> wrote: >> Hi, James, >> >> Is it suitable to add this line in arch/mips/include/asm/mmzone.h? >> #define pa_to_nid(addr) 0 > > It was basically malta_defconfig. > > OTOH when i tried including asm/mmzone.h, that tries including <mmzone.h> which it can't find. > > Cheers > Jamee > <asm/mmzone.h> is only supposed to be defined for NUMA-aware systems, as far as I can tell. I believe a lot of the Loongson code derives somewhat from the IP27 code, as both are the only MIPS platforms that define a specific version of that header. It also looks like the generic mmzone.h header probably just needs the <mmzone.h> include removed. pa_to_nid is only used for pfn_to_nid when CONFIG_DISCONTIGMEM is set, and IP27 is one of the only platforms that uses that memory model. --J