Re: [PATCH] writeback: Fix occasional slow sync(1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu 15-08-13 15:15:04, Andrew Morton wrote:
> On Mon, 15 Jul 2013 11:45:14 +0200 Jan Kara <jack@xxxxxxx> wrote:
> 
> > In case when system contains no dirty pages, wakeup_flusher_threads()
> > will submit WB_SYNC_NONE writeback for 0 pages so wb_writeback() exits
> > immediately without doing anything. Thus sync(1) will write all the
> > dirty inodes from a WB_SYNC_ALL writeback pass which is slow.
> > 
> > Fix the problem by using get_nr_dirty_pages() in
> > wakeup_flusher_threads() instead of calculating number of dirty pages
> > manually. That function also takes number of dirty inodes into account.
> 
> Fair enough.
> 
> > CC: stable@xxxxxxxxxxxxxxx
> 
> Unexpected.  What was your thinking here?
  Right, probably the problem isn't serious enough. Just discard the CC
please. Thanks!

								Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]