Re: [PATCH for-4.9 3/7] rt2x00: avoid introducing a USB dependency in the rt2x00lib module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 26, 2017 at 01:31:27PM +0530, Amit Pundir wrote:
> From: Stanislaw Gruszka <sgruszka@xxxxxxxxxx>
> 
> commit 6232c17438ed01f43665197db5a98a4a4f77ef47 upstream.
> 
> As reported by Felix:
> 
> Though protected by an ifdef, introducing an usb symbol dependency in
> the rt2x00lib module is a major inconvenience for distributions that
> package kernel modules split into individual packages.
> 
> Get rid of this unnecessary dependency by calling the usb related
> function from a more suitable place.
> 
> Cc: Vishal Thanki <vishalthanki@xxxxxxxxx>
> Reported-by: Felix Fietkau <nbd@xxxxxxxx>
> Fixes: 8b4c0009313f ("rt2x00usb: Use usb anchor to manage URB")
> Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx>
> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> Signed-off-by: Amit Pundir <amit.pundir@xxxxxxxxxx>
> ---
>  drivers/net/wireless/ralink/rt2x00/rt2x00dev.c | 23 ++++++++---------------
>  drivers/net/wireless/ralink/rt2x00/rt2x00usb.c |  5 +++++
>  2 files changed, 13 insertions(+), 15 deletions(-)

I keep skipping this patch, but people keep submitting it, so I might as
well give in and take it this time :)

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]