On Thu, Jun 15, 2017 at 10:42:30PM +0800, Yao Lihua wrote:
> Hi Krzysztof,
>
> Another Oops on S3C6410.
(...)
> diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
> > index f542642eed8d..a25c3ffae25c 100644
> > --- a/drivers/pinctrl/samsung/pinctrl-samsung.c
> > +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
> > @@ -1013,6 +1013,11 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,
> > bank->eint_base = virt_base[0];
> > bank->pctl_base = virt_base[bdata->pctl_res_idx];
> > }
> > + /*
> > + * For legacy platforms which need to access IO memory through
> > + * samsung_pinctrl_drv_data:
> > + */
> > + d->virt_base = virt_base[bdata->pctl_res_idx];
> >
> for (i = 0; i < ctrl->nr_banks; ++i, ++bdata, ++bank) {
> ......
> }
> /*
> * For legacy platforms which need to access IO memory through
> * samsung_pinctrl_drv_data:
> */
> d->virt_base = virt_base[bdata->pctl_res_idx];
> ^
> **bdata** is invalid here.
Ah, of course, apparently it worked in my case by coincidence. Thanks
for spotting this.
Best regards,
Krzysztof