Re: [PATCH 4.11 145/150] tracing: Use strlcpy() instead of strcpy() in __trace_find_cmdline()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 12, 2017 at 12:25:39PM -0400, Steven Rostedt wrote:
> On Mon, 12 Jun 2017 18:05:00 +0200
> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > > Link: http://lkml.kernel.org/r/1493806274-13936-1-git-send-email-amit.pundir@xxxxxxxxxx
> 
> > Hm, Amit asked me to merge all of these for some reason.  I guess people
> > see the "oh, look, strcpy is bad!" and jump to wrong conclusions.
> 
> I said the same thing when accepting it. From the thread that is
> referenced by the Link tag:
> 
> https://marc.info/?l=linux-kernel&m=149382004318095&w=2
> 
> "Note, I don't see anyway to trigger a bug. To me this looks simply like
> someone saw "strcpy" and said to themselves "oh this is a bug", when
> actuality it is not. I don't mind the extra security added, but I don't
> think this even needs to go to stable. The reason is that the comm used
> within the kernel is always created by the kernel, and always has a
> terminating nul character. There's other places in the kernel that will
> bug if that is not true."

Ok, I've now dropped this patch from all stable queues, sorry for the
noise.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]