RE: [PATCH] Call echo service immediately after socket reconnect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2017-06-12 12:16 GMT-07:00 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>:
> On Mon, Jun 12, 2017 at 07:08:51PM +0000, Pavel Shilovskiy wrote:
>> 2017-06-12 5:30 GMT-07:00 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>:
>> > On Mon, Jun 05, 2017 at 12:15:21PM -0700, Pavel Shilovsky wrote:
>> >> From: Sachin Prabhu <sprabhu@xxxxxxxxxx>
>> >>
>> >> Commit b8c600120fc8 ("Call echo service immediately after socket
>> >> reconnect") upstream.
>> >>
>> >> Commit 4fcd1813e640 ("Fix reconnect to not defer smb3 session reconnect
>> >> long after socket reconnect") changes the behaviour of the SMB2 echo
>> >> service and causes it to renegotiate after a socket reconnect. However
>> >> under default settings, the echo service could take up to 120 seconds to
>> >> be scheduled.
>> >>
>> >> The patch forces the echo service to be called immediately resulting a
>> >> negotiate call being made immediately on reconnect.
>> >>
>> >> Signed-off-by: Sachin Prabhu <sprabhu@xxxxxxxxxx>
>> >> Reviewed-by: Pavel Shilovsky <pshilov@xxxxxxxxxxxxx>
>> >> Signed-off-by: Steve French <smfrench@xxxxxxxxx>
>> >> Acked-by: Sachin Prabhu <sprabhu@xxxxxxxxxx>
>> >> Signed-off-by: Pavel Shilovsky <pshilov@xxxxxxxxxxxxx>
>> >> ---
>> >>  fs/cifs/connect.c | 24 ++++++++++++++++++------
>> >>  1 file changed, 18 insertions(+), 6 deletions(-)
>> >
>> > What stable tree(s) do you want this applied to?  Please be specific
>> > like the documentation tells you to do :)
>> >
>> > And CIFS maintainers, come on, your subject lines for patches suck,
>> > please use a prefix like _everyone_ else does to make it more obvious
>> > what part of the kernel is being touched.
>>
>> This patch is targeted for kernels below v4.9, in particular - for
>> v4.4 and v3.18 stable kernels. Do you want me to re-send the patch to
>> comply with the documentation?
>
> Please do.

Done. I specified the targeted kernels as a range (Cc: <stable@xxxxxxxxxxxxxxx> # 3.18.x-4.4.x). Please let me know if I need to be more specific and specify particular versions instead.

--
Best regards,
Pavel Shilovsky





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]