Re: [PATCH 02/25] xfs: rework the inline directory verifiers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 05, 2017 at 04:06:00PM +0200, Greg KH wrote:
> On Sat, Jun 03, 2017 at 03:18:13PM +0200, Christoph Hellwig wrote:
> > From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
> > 
> > The inline directory verifiers should be called on the inode fork data,
> > which means after iformat_local on the read side, and prior to
> > ifork_flush on the write side.  This makes the fork verifier more
> > consistent with the way buffer verifiers work -- i.e. they will operate
> > on the memory buffer that the code will be reading and writing directly.
> > 
> > Furthermore, revise the verifier function to return -EFSCORRUPTED so
> > that we don't flood the logs with corruption messages and assert
> > notices.  This has been a particular problem with xfs/348, which
> > triggers the XFS_WANT_CORRUPTED_RETURN assertions, which halts the
> > kernel when CONFIG_XFS_DEBUG=y.  Disk corruption isn't supposed to do
> > that, at least not in a verifier.
> > 
> > Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>
> > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> Commit 78420281a9d74014af7616958806c3aba056319e, right?

Yes.  Sorry for not including it.



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]