On Tue, 2017-05-23 at 16:48 -0700, Bart Van Assche wrote: > For VERIFY and WRITE AND VERIFY commands the size of the SCSI > Data-Out buffer can differ from the size of the data area on the > storage medium that is affected by the command. Make sure that > the Data-Out buffer size is computed correctly if the BYTCHK > field in the CDB is zero. This patch reverts commit 984a9d4c40be > and thereby restores commit 0e2eb7d12eaa. Additionally, > sbc_parse_cdb() is modified such that the data buffer size is > computed correctly for the affected commands if BYTCHK == 0. > This patch is the combination of two patches that got positive > reviews. > > References: commit 984a9d4c40be ("Revert "target: Fix VERIFY and WRITE VERIFY command parsing"") > References: commit 0e2eb7d12eaa ("target: Fix VERIFY and WRITE VERIFY command parsing") > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx> > Cc: Hannes Reinecke <hare@xxxxxxxx> > Cc: Christoph Hellwig <hch@xxxxxx> > Cc: Andy Grover <agrover@xxxxxxxxxx> > Cc: David Disseldorp <ddiss@xxxxxxx> > Cc: <stable@xxxxxxxxxxxxxxx> > --- > drivers/target/target_core_sbc.c | 79 ++++++++++++++++++++++++++++++++++------ > 1 file changed, 67 insertions(+), 12 deletions(-) > This patch ignored the review comments from the last round: http://www.spinics.net/lists/target-devel/msg15306.html http://www.spinics.net/lists/target-devel/msg15327.html Until these are addressed as requested, dropping this patch for now.