Hi Thomas, Thanks for the prompt reply. Agree on points. we will validate at our end and shall provide the update. Nehal -----Original Message----- From: Thomas Gleixner [mailto:tglx@xxxxxxxxxxxxx] Sent: Friday, May 26, 2017 12:19 PM To: Shah, Nehal-bakulchandra <Nehal-bakulchandra.Shah@xxxxxxx> Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>; Linus Walleij <linus.walleij@xxxxxxxxxx>; linux-gpio@xxxxxxxxxxxxxxx; Borislav Petkov <bp@xxxxxxxxx>; Xue, Ken <Ken.Xue@xxxxxxx>; S-k, Shyam-sundar <Shyam-sundar.S-k@xxxxxxx>; stable@xxxxxxxxxxxxxxx Subject: RE: [PATCH] pinctrl/amd: Use regular interrupt instead of chained Nehal, On Fri, 26 May 2017, Shah, Nehal-bakulchandra wrote: > Thanks for the patch. However, we have received this issue from > multiple people and different disro but it occurs only on Gigabyte > hardware. With reference AM4 ryzen board we are not facing this issue. > We are in discussion with gigabyte to check the BIOS part. Once we > have clarity on that, we can consider driver part. Also, this code is > running on multiple platform of different customers so changing > directly at this point of time may be risky in my point of view. > Requesting you to hold this patch till we get clarity on bios end. It does not matter at all whether this is a problem only on GB hardware. Fact is, that this happened and it will happen again. The patch does not change any functionality of the driver, it merily makes it more robust and spares users the bloody annoying experience of a non booting machine and the tedious task of figuring out why. The main objective of the kernel is robustness and not pleasing the ego of silicon vendors. We can't prevent the stupidity of BIOS people, we merily can deal with it. That patch should go into mainline ASAP and backported to stable in order to help those people who bought wreckaged hardware. Thanks, tglx