On Tue, May 23, 2017 at 11:53 PM, Olof's autobuilder <build@xxxxxxxxx> wrote: > Here are the build results from automated periodic testing. > > The tree being built was stable-rc, found at: > > https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable-rc.git/ > > 35c7f23 Linux 3.18.55-rc1 > Warnings: > > 2 include/linux/stddef.h:8:14: warning: 'return' with a value, in function returning void > 57 drivers/of/fdt.c:384:10: warning: 'return' with a value, in function returning void Caused by the backport of 0aa459efa045 ("of: fdt: add missing allocation-failure check") which relies on another change from: 83262418b0ef ("drivers/of: Return allocated memory from of_fdt_unflatten_tree()") Possible fixes are a) drop 0aa459efa045, as it won't be that important on 3.18: DT overlays were added only in 3.19, so this won't ever be called at runtime, and we don't normally worry about kmalloc failures during early boot. b) backport 83262418b0ef, which is otherwise not needed on stable c) apply or fold the trivial fixup: 8<-------- [stable 3.18] fix __unflatten_device_tree warning A backported patch needs to be modified for a context change drivers/of/fdt.c:384:10: warning: 'return' with a value, in function returning void Fixes: 0aa459efa045 ("of: fdt: add missing allocation-failure check") Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index 43bd69dceabf..ca352d3a7d7e 100644 --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c @@ -508,7 +508,7 @@ void *__unflatten_device_tree(const void *blob, /* Allocate memory for the expanded device tree */ mem = dt_alloc(size + 4, __alignof__(struct device_node)); if (!mem) - return NULL; + return; memset(mem, 0, size);