Re: [PATCH 1/2] ext4 crypto: don't let data integrity writebacks fail with ENOMEM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 22, 2017 at 04:37:51PM -0700, Eric Biggers wrote:
> From: Theodore Ts'o <tytso@xxxxxxx>
> 
> commit c9af28fdd44922a6c10c9f8315718408af98e315 upstream.  [Please apply
> to 4.4-stable.  This fixes a bug which has caused problems on both
> Android and Chrome OS, and this fix has already been included in a
> number of ext4 encryption backports.]
> 
> We don't want the writeback triggered from the journal commit (in
> data=writeback mode) to cause the journal to abort due to
> generic_writepages() returning an ENOMEM error.  In addition, if
> fsync() fails with ENOMEM, most applications will probably not do the
> right thing.
> 
> So if we are doing a data integrity sync, and ext4_encrypt() returns
> ENOMEM, we will submit any queued I/O to date, and then retry the
> allocation using GFP_NOFAIL.
> 
> Google-Bug-Id: 27641567
> 
> Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

Thanks for both of these, now queued up.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]