On 05/20/2017 05:56 AM, Ming Lei wrote: > Inside nvme_kill_queues(), we have to start hw queues for > draining requests in sw queues, .dispatch list and requeue list, > so use blk_mq_start_hw_queues() instead of blk_mq_start_stopped_hw_queues() > which only run queues if queues are stopped, but the queues may have > been started already, for example nvme_start_queues() is called in reset work > function. > > blk_mq_start_hw_queues() run hw queues in current context, instead > of running asynchronously like before. Given nvme_kill_queues() is > run from either remove context or reset worker context, both are fine > to run hw queue directly. And the mutex of namespaces_mutex isn't a > problem too becasue nvme_start_freeze() runs hw queue in this way > already. > > Cc: stable@xxxxxxxxxxxxxxx > Reported-by: Zhang Yi <yizhan@xxxxxxxxxx> > Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx> > --- Looks good, Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx> -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850