On Thu, 2017-05-11 at 16:13 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b upstream.
>
> We accidentally return an uninitialized variable on success.
No we don't.
> Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler")
Actually fixes: b78205c93297 ("scsi_dh_emc: switch to
scsi_execute_req_flags()") so this is only needed for 4.11.y.
Ben.
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
> Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> ---
> drivers/scsi/device_handler/scsi_dh_emc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/scsi/device_handler/scsi_dh_emc.c
> +++ b/drivers/scsi/device_handler/scsi_dh_emc.c
> @@ -456,7 +456,7 @@ static int clariion_prep_fn(struct scsi_
> static int clariion_std_inquiry(struct scsi_device *sdev,
> struct clariion_dh_data *csdev)
> {
> - int err;
> + int err = SCSI_DH_OK;
> char *sp_model;
>
> err = send_inquiry_cmd(sdev, 0, csdev);
>
>
>
--
Ben Hutchings
Software Developer, Codethink Ltd.