On Thu, May 11, 2017 at 02:46:37PM -0700, Tony Lindgren wrote: > * Matthijs van Duin <matthijsvanduin@xxxxxxxxx> [170511 14:34]: > > On Thu, May 11, 2017 at 02:16:07PM -0700, Guenter Roeck wrote: > > > arch/arm/mach-omap2/omap-headsmp.S:60: Error: bad instruction `badr r0,hyp_boot' > > > > > > I see "badr" used in later kernels, but not in v3.18. Does this possibly > > > require some secondary patches ? > > > > It was introduced in kernel 4.2 by > > 14327c662822 "ARM: replace BSYM() with badr assembly macro" > > > > The correct backport would therefore just be: > > > > - adr r0, hyp_boot > > + adr r0, BSYM(hyp_boot) > > > > Right? > > Or just skip this for v3.18 until somebody actually needs thumb > kernel with hypervisor and can provide a Tested-by. Ok, I'll drop this patch for now, it was added to fix a build warning that Arnd found. I'll wait for a proper backport if people really get annoyed by it :) thanks, greg k-h