On Mon, Aug 05, 2013 at 12:51:17PM +0200, Lars-Peter Clausen wrote: > On 08/05/2013 12:15 PM, Luis Henriques wrote: > > <gregkh@xxxxxxxxxxxxxxxxxxx> writes: > > > >> This is a note to let you know that I've just added the patch titled > >> > >> dma: pl330: Fix cyclic transfers > >> > >> to the 3.4-stable tree which can be found at: > >> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > >> > >> The filename of the patch is: > >> dma-pl330-fix-cyclic-transfers.patch > >> and it can be found in the queue-3.4 subdirectory. > >> > >> If you, or anyone else, feels it should not be added to the stable tree, > >> please let <stable@xxxxxxxxxxxxxxx> know about it. > >> > > > > While working on this patch for the 3.5 kernel I found it breaks the > > kernel build for 2 reasons: > > > > * is_slave_direction() is not defined (although you could cherry-pick > > 61cc13a51bcff737ce02d2047834171c0365b00d commit) > > I think the best option is to cherry-pick that commit, it is small and > self-contained. The alternative is to respin the patch for stable with the > function open-coded. > > > > > * function pl330_prep_dma_cyclic() signature doesn't contain the > > 'flags' parameter introduced by commit > > ec8b5e48c03790a68cb875fe5064007a9cbdfdd0 > > Hm, that's actually a bug in the original patch. spin_lock_irqsave() should > not be using the flags parameter, but instead a variable placed on the > stack. Things will still work by using the parameter, but it's not exactly > how things are supposed to be done. Given this is a mess, I'm going to drop it from 3.4.x, I doubt it's really needed there, right? If so, please resend the proper series, fixed up to work. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html