On Fri, 2017-05-05 at 10:53 +0200, Christoph Hellwig wrote: > But as a further step can we try to move the waiting behavior entirely > into the caller that actually cares, > > e.g. move the conditional target_wait_free_cmd before the call > to transport_generic_free_cmd in transport_generic_free_cmd, > and move this second wait_for_completion after the > transport_generic_free_cmd call based on an indicator (return value > or se_cmd flag)? Hello Christoph, That sounds like a good idea to me, especially since there are only three target drivers that set the "wait_for_tasks" argument to true, namely tcm_loop, the iSCSI target driver and the xen-scsiback driver. Bart.