On 05/05/2017 12:51 AM, Bart Van Assche wrote: > Move timer initialization from before add_timer() to the context > where the containing object is initialized. Use setup_timer() and > mod_timer() instead of open coding these. Use 'jiffies' instead > of get_jiffies_64() when calculating expiry times because expiry > times have type unsigned long, just like 'jiffies'. > > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx> > Cc: Hannes Reinecke <hare@xxxxxxxx> > Cc: Christoph Hellwig <hch@xxxxxx> > Cc: Andy Grover <agrover@xxxxxxxxxx> > Cc: David Disseldorp <ddiss@xxxxxxx> > Cc: <stable@xxxxxxxxxxxxxxx> > --- > drivers/target/iscsi/iscsi_target.c | 3 +++ > drivers/target/iscsi/iscsi_target_erl0.c | 10 +++------- > drivers/target/iscsi/iscsi_target_erl0.h | 1 + > drivers/target/iscsi/iscsi_target_erl1.c | 8 ++------ > drivers/target/iscsi/iscsi_target_erl1.h | 1 + > drivers/target/iscsi/iscsi_target_login.c | 16 ++++++++++------ > drivers/target/iscsi/iscsi_target_login.h | 1 + > drivers/target/iscsi/iscsi_target_nego.c | 8 +++----- > drivers/target/iscsi/iscsi_target_util.c | 26 ++++++++------------------ > drivers/target/iscsi/iscsi_target_util.h | 2 ++ > 10 files changed, 34 insertions(+), 42 deletions(-) Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)