Re: [PATCH for-3.18 3/7] perf: Tighten (and fix) the grouping condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3 May 2017 at 23:12, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, May 3, 2017 at 10:35 AM, Amit Pundir <amit.pundir@xxxxxxxxxx> wrote:
>>
>> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
>> (cherry picked from commit c3c87e770458aa004bd7ed3f29945ff436fd6511)
>> Signed-off-by: Amit Pundir <amit.pundir@xxxxxxxxxx>
>
> When sending things to the stable tree, it's better to make that
> upstream information explicit at the top, rather than hiding it like
> this in the sign-off change.
>
> IOW, just somethuing like
>
>    "commit c3c87e770458aa004bd7ed3f29945ff436fd6511 upstream"
>
> as the first line of the body (not the subject line) tends to be the
> standard way.
>
> I suspect Greg edits things that way anyway, but it presumably helps
> if it's already in the right format.
>
> That way i*really* stands out what commit that is upstream.

Thanks. I'll take care of the format from next time.

Regards,
Amit Pundir

>
>                     Linus



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]