Re: Patch "cgroup: fix umount vs cgroup_cfts_commit() race" has been added to the 3.10-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 05, 2013 at 01:32:29PM +0800, Li Zefan wrote:
> Hi Greg,
> 
> > --- a/kernel/cgroup.c
> > +++ b/kernel/cgroup.c
> > @@ -2769,13 +2769,17 @@ static void cgroup_cfts_commit(struct cg
> >  {
> >  	LIST_HEAD(pending);
> >  	struct cgroup *cgrp, *n;
> > +	struct super_block *sb = ss->root->sb;
> >  
> >  	/* %NULL @cfts indicates abort and don't bother if @ss isn't attached */
> > -	if (cfts && ss->root != &rootnode) {
> > +	if (cfts && ss->root != &rootnode &&
> > +	    atomic_inc_not_zero(sb->s_active)) {
> 
> You can either change (sb->s_active) to (&sb->s_active), or you can apply
> the backport I sent a few days ago:
> 
> www.spinics.net/lists/stable/msg14543.html
> 
> Otherwise this won't compile...

Ah, my fault, I had made that change, but not run 'quilt refresh' to
update it in the patch.  I've now done that and pushed it out, as yes,
you are right, it didn't build :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]