Re: [PATCH] Fix for compilation with clang

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 25, 2017 at 09:56:29AM +0200, Hans Petter Selasky wrote:
> The clang compiler treats the memory address of a structure field as
> tautologically true when compared to non-NULL. This breaks the macros
> in llist.h when compiled using clang. Fix this by not comparing the
> address of a structure field to NULL when determining the end of the
> llist. Refer to -Wtautological-pointer-compare in clang for more
> information.
> 
> Signed-off-by: Hans Petter Selasky <hps@xxxxxxxxxxx>
> ---
>  include/linux/llist.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

Also, this is not how to get a patch accepted into the main kernel tree
either, please read the SubmittingPatches documentaion for how to do
that correctly.

good luck!

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]