This is a note to let you know that I've just added the patch titled
zram: protect sysfs handler from invalid memory access
to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
zram-protect-sysfs-handler-from-invalid-memory-access.patch
and it can be found in the queue-3.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 5863e10b441e7ea4b492f930f1be180a97d026f3 Mon Sep 17 00:00:00 2001
From: Jiang Liu <liuj97@xxxxxxxxx>
Date: Fri, 7 Jun 2013 00:07:27 +0800
Subject: zram: protect sysfs handler from invalid memory access
From: Jiang Liu <liuj97@xxxxxxxxx>
commit 5863e10b441e7ea4b492f930f1be180a97d026f3 upstream.
Use zram->init_lock to protect access to zram->meta, otherwise it
may cause invalid memory access if zram->meta has been freed by
zram_reset_device().
This issue may be triggered by:
Thread 1:
while true; do cat mem_used_total; done
Thread 2:
while true; do echo 8M > disksize; echo 1 > reset; done
Signed-off-by: Jiang Liu <jiang.liu@xxxxxxxxxx>
Acked-by: Minchan Kim <minchan@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/staging/zram/zram_sysfs.c | 2 ++
1 file changed, 2 insertions(+)
--- a/drivers/staging/zram/zram_sysfs.c
+++ b/drivers/staging/zram/zram_sysfs.c
@@ -188,8 +188,10 @@ static ssize_t mem_used_total_show(struc
struct zram *zram = dev_to_zram(dev);
struct zram_meta *meta = zram->meta;
+ down_read(&zram->init_lock);
if (zram->init_done)
val = zs_get_total_size_bytes(meta->mem_pool);
+ up_read(&zram->init_lock);
return sprintf(buf, "%llu\n", val);
}
Patches currently in stable-queue which might be from liuj97@xxxxxxxxx are
queue-3.10/zram-avoid-access-beyond-the-zram-device.patch
queue-3.10/zram-protect-sysfs-handler-from-invalid-memory-access.patch
queue-3.10/zram-avoid-double-free-in-function-zram_bvec_write.patch
queue-3.10/zram-use-zram-lock-to-protect-zram_free_page-in-swap-free-notify-path.patch
queue-3.10/zram-avoid-invalid-memory-access-in-zram_exit.patch
queue-3.10/zram-destroy-all-devices-on-error-recovery-path-in-zram_init.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html