Re: [PATCH v4.4, v4.9] usb: dwc3: gadget: delay unmap of bounced requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> writes:
> On Mon, Apr 10, 2017 at 06:00:07PM +0300, Felipe Balbi wrote:
>> From: Janusz Dziedzic <januszx.dziedzic@xxxxxxxxx>
>> 
>> commit de288e36fe33f7e06fa272bc8e2f85aa386d99aa upstream.
>> 
>> In the case of bounced ep0 requests, we must delay DMA operation until
>> after ->complete() otherwise we might overwrite contents of req->buf.
>> 
>> This caused problems with RNDIS gadget.
>> 
>> Cc: <stable@xxxxxxxxxxxxxxx> # v4.4 v4.9
>> Fixes: d62145929992 ("usb: dwc3: gadget: always unmap EP0 requests")
>> Signed-off-by: Janusz Dziedzic <januszx.dziedzic@xxxxxxxxx>
>> Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx>
>> ---
>> 
>> cherry-picked, fixed up and compile tested
>
> This only would apply to 4.9-stable, 4.4-stable it still fails:
> 	patching file drivers/usb/dwc3/gadget.c
> 	Hunk #1 succeeded at 1193 with fuzz 2 (offset 1019 lines).
> 	Hunk #2 FAILED at 183.
> 	Hunk #3 FAILED at 195.
> 	2 out of 3 hunks FAILED -- rejects in file drivers/usb/dwc3/gadget.c
>
> Care to send one for that tree?

dang, don't remember that code changing. Will do it shortly.

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]