Re: Merge of "virtio_net: fix race in RX VQ processing" for linux-3.2.48

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ben Hutchings <ben@xxxxxxxxxxxxxxx> writes:

> On Sun, 2013-07-28 at 10:15 +0300, Michael S. Tsirkin wrote:
>> On Sun, Jul 28, 2013 at 04:40:50AM +0100, Ben Hutchings wrote:
>> > On Sat, 2013-07-27 at 22:51 +0200, Wolfram Gloger wrote:
>> > > Ben Hutchings <ben@xxxxxxxxxxxxxxx> writes:
>> > > 
>> > > > This sounds like it could be suitable for stable, but that doesn't seem
>> > > > to have been requested by the author.  I'm cc'ing those involved so they
>> > > > can make a decision whether this should be included in 3.2.y or other
>> > > > stable branches.
>> > > 
>> > > What alarmed me - as an extensive virtio user - was that Michael stated:
>> > > 
>> > >      The race has been there from day 1, but it got especially nasty in
>> > >      3.0 when commit a5c262c5fd83ece01bd649fb08416c501d4c59d7
>> > >      "virtio_ring: support event idx feature" added more dependency on
>> > >      vq state.
>> > > 
>> > > > Thanks, but these are not in quite the right patch format.
>> > > 
>> > > Oh sorry, I didn't think you might take this directly as produced by me.
>> > > Hope these are better?
>> > 
>> > David and Michael, please consider these backports for Linux 3.2.  It
>> > looks like these should also work for 3.0, while for 3.4
>> > virtqueue_enable_cb() already has a kernel-doc comment and the
>> > virtio_ring patch would need to be adjusted for that.
>> > 
>> > Ben.
>> 
>> The backports look good to me.
>
> OK, I've queued these up for 3.2.  Greg, please queue up the attached
> patches for 3.0 and 3.4:
>
> 3.0: virtio-race-1of2.diff, virtio-race-2of2.diff
> 3.4: virtio-race-1of2.diff, virtio-race-2of2-3.4.diff
>
> Ben.

I'm queued these for the 3.5 kernel as well.

Cheers,
-- 
Luis
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]