Re: [PATCH 51/98] scsi: ufs: refactor device descriptor reading

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 04, 2017 at 07:32:21PM +0000, alexander.levin@xxxxxxxxxxx wrote:
> From: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> 
> [ Upstream commit 93fdd5ac64bbe80dac6416f048405362d7ef0945 ]
> 
> Pull device descriptor reading out of ufs quirk so it can be used also
> for other purposes.
> 
> Revamp the fixup setup:
> 
> 1. Rename ufs_device_info to ufs_dev_desc as very similar name
>    ufs_dev_info is already in use.
> 
> 2. Make the handlers static as they are not used out of the ufshdc.c
>    file.
> 
> [mkp: applied by hand]
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> Reviewed-by: Subhash Jadavani <subhashj@xxxxxxxxxxxxxx>
> Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
> ---
>  drivers/scsi/ufs/ufs.h        | 12 ++++++++++++
>  drivers/scsi/ufs/ufs_quirks.h | 28 ++++++----------------------
>  drivers/scsi/ufs/ufshcd.c     | 40 +++++++++++++++++++---------------------
>  3 files changed, 37 insertions(+), 43 deletions(-)

Why is this patch needed?  You don't add any ufs quirks after it in the
series that I can see...

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]