On Wed, Apr 05, 2017 at 02:07:46PM +0000, alexander.levin@xxxxxxxxxxx wrote: > On Wed, Apr 05, 2017 at 12:16:49PM +0200, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > On Tue, Apr 04, 2017 at 07:32:02PM +0000, alexander.levin@xxxxxxxxxxx wrote: > > > From: Chen-Yu Tsai <wens@xxxxxxxx> > > > > > > [ Upstream commit 91ea2f29cba6a7fe035ea232e4f981211a9fce5d ] > > > > > > We already have some differences between the 2 supported SoCs. > > > More will be added as we support other SoCs. To avoid bloating > > > the probe function with even more conditionals, move the quirks > > > to a separate data structure that's tied to the compatible string. > > > > > > Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx> > > > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> > > > Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx> > > > --- > > > drivers/gpu/drm/sun4i/sun4i_tcon.c | 33 ++++++++++++++++++--------------- > > > drivers/gpu/drm/sun4i/sun4i_tcon.h | 11 +++++++---- > > > 2 files changed, 25 insertions(+), 19 deletions(-) > > > > What new hardware is this enabling? It looks like this is just code > > reorginizing to me, to make things easier for later patches, which I > > don't see in this patch series... > > Uh, right, I pulled it in for: > > 49c440e87cd ("drm/sun4i: Add compatible strings for A31/A31s display pipelines") > 93a5ec14da2 ("drm/sun4i: Add compatible string for A31/A31s TCON (timing controller)") > > I'm not sure where they went, can you pull them in please? Now pulled in, thanks! greg k-h