Hi James,
On 6 April 2017 at 14:59, James Hogan <james.hogan@xxxxxxxxxx> wrote:
> Hi Amit,
>
> On Wed, Apr 05, 2017 at 04:01:56PM +0530, Amit Pundir wrote:
>> From: Felix Fietkau <nbd@xxxxxxxx>
>>
>> With the IRQ stack changes integrated, the XRX200 devices started
>> emitting a constant stream of kernel messages like this:
>>
>> [ 565.415310] Spurious IRQ: CAUSE=0x1100c300
>>
>> This is caused by IP0 getting handled by plat_irq_dispatch() rather than
>> its vectored interrupt handler, which is fixed by commit de856416e714
>> ("MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch").
>>
>> Fix plat_irq_dispatch() to handle non-vectored IPI interrupts correctly
>> by setting up IP2-6 as proper chained IRQ handlers and calling do_IRQ
>> for all MIPS CPU interrupts.
>>
>> Signed-off-by: Felix Fietkau <nbd@xxxxxxxx>
>> Acked-by: John Crispin <john@xxxxxxxxxxx>
>> Cc: linux-mips@xxxxxxxxxxxxxx
>> Patchwork: https://patchwork.linux-mips.org/patch/15077/
>> [james.hogan@xxxxxxxxxx: tweaked commit message]
>> Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx>
>>
>> (cherry picked from commit 6c356eda225e3ee134ed4176b9ae3a76f793f4dd)
>> Signed-off-by: Amit Pundir <amit.pundir@xxxxxxxxxx>
>
> Is there a particular reason this is desired in stable? I was under the
> impression it was only helpful in the presence of a bug in the separate
> IRQ stack stuff in 4.11, which was fixed in the above mentioned commit
> de856416e714 ("MIPS: IRQ Stack: Fix erroneous jal to
> plat_irq_dispatch"), and otherwise just a nice to have cleanup.
I picked up this patch from Lede source tree
https://github.com/lede-project/source/ for stable 4.9.
>
> If you've cherry picked the IRQ stack work, have you also cherry-picked
> de856416e714?
Thanks for pointing it out. I indeed missed out on picking
de856416e714 ("MIPS: IRQ Stack: Fix erroneous jal to
plat_irq_dispatch") and dda45f701c9d ("MIPS: Switch to the irq_stack
in interrupts"). Should I pick them too for 4.9/4.10 stable or drop
these 3 IRQ stack patches altogether if they are not stable material?
Regards,
Amit Pundir
>
> Cheers
> James