On Tue, Apr 04, 2017 at 11:31:46AM +0200, Rafał Miłecki wrote:
> Hi Amit,
>
> On 2017-04-04 08:12, Amit Pundir wrote:
> > From: Rafał Miłecki <rafal@xxxxxxxxxx>
> >
> > Since early BCM5301X days we got abort handler that was removed by
> > commit 937b12306ea79 ("ARM: BCM5301X: remove workaround imprecise abort
> > fault handler"). It assumed we need to deal only with pending aborts
> > left by the bootloader. Unfortunately this isn't true for BCM5301X.
> >
> > When probing PCI config space (device enumeration) it is expected to
> > have master aborts on the PCI bus. Most bridges don't forward (or they
> > allow disabling it) these errors onto the AXI/AMBA bus but not the
> > Northstar (BCM5301X) one.
> >
> > iProc PCIe controller on Northstar seems to be some older one, without
> > a control register for errors forwarding. It means we need to workaround
> > this at platform level. All newer platforms are not affected by this
> > issue.
> >
> > Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>
> > Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> > (cherry picked from commit 09f3510fb70a46c8921f2cf4a90dbcae460a6820)
> > Signed-off-by: Amit Pundir <amit.pundir@xxxxxxxxxx>
>
> I'm sorry but I'm not familiar with your work and I'm missing some cover
> letter explaining what these patches are about.
>
> You seem to be sending this stuff to Greg. Do you wan to have to included in
> some particular stable branch? Which one? Why? Some of these patches are
> clean
> ups, not a really important fixes.
Are the cleanups needed for the "important fixes" that happen later in
the patch series? If not, why would they be in the repo that Amit
pulled these from? Do those developers just blindly backport stuff in?
(might be true, don't know who they are...)
thanks,
greg k-h