On Thu, Mar 30, 2017 at 12:16:14PM +0100, Chris Wilson wrote: > Michał Winiarski pointed out that the debugging infrastructure (such as > trace_dma_fence_release) likes to pretty print the timeline name, long > after we have freed the timeline. Our timelines currently live as part of > the GTT (due to the strict ordering we current use through each) which s/current/currently/ > belong to the context. We aim to free the context and release its > hardware resources as soon as we able to (i.e. when the last > fence/request using it has been signaled and retired). As the > .get_timeline_name is purely a debug feature, rather than extending the > lifetime of the context, or splitting it into many different release > phases just to keep the name along, replace the timeline name with a s/along/around/ > constant after the fence has been signaled. This avoids the potential > use-after-free. -Chris -- Chris Wilson, Intel Open Source Technology Centre