Re: [PATCH 3.10-stable] xen: Fixed assignment error in if statement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 01, 2013 at 11:21:14PM +0900, Jonghwan Choi wrote:
> From: Lisa Nguyen <lisa@xxxxxxxxxxxxxxx>
> 
> This patch looks like it should be in the 3.10-stable tree, should we apply
> it?

It is not fixing a critical bug so I would say no.

thanks!
> 
> ------------------
> 
> From: "Lisa Nguyen <lisa@xxxxxxxxxxxxxxx>"
> 
> commit fce92683570c2ddcdb82cde67b0b07800106fbd9 upstream
> 
> Fixed assignment error in if statement in balloon.c
> 
> Signed-off-by: Lisa Nguyen <lisa@xxxxxxxxxxxxxxx>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Signed-off-by: Jonghwan Choi <jhbird.choi@xxxxxxxxxxx>
> ---
>  drivers/xen/balloon.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
> index a56776d..930fb68 100644
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -407,7 +407,8 @@ static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp)
>  		nr_pages = ARRAY_SIZE(frame_list);
>  
>  	for (i = 0; i < nr_pages; i++) {
> -		if ((page = alloc_page(gfp)) == NULL) {
> +		page = alloc_page(gfp);
> +		if (page == NULL) {
>  			nr_pages = i;
>  			state = BP_EAGAIN;
>  			break;
> -- 
> 1.8.1.2
> 
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]