Patch "uwb: hwa-rc: fix NULL-deref at probe" has been added to the 4.9-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    uwb: hwa-rc: fix NULL-deref at probe

to the 4.9-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     uwb-hwa-rc-fix-null-deref-at-probe.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.


>From daf229b15907fbfdb6ee183aac8ca428cb57e361 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@xxxxxxxxxx>
Date: Mon, 13 Mar 2017 13:47:52 +0100
Subject: uwb: hwa-rc: fix NULL-deref at probe

From: Johan Hovold <johan@xxxxxxxxxx>

commit daf229b15907fbfdb6ee183aac8ca428cb57e361 upstream.

Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer should a malicious device lack endpoints.

Note that the dereference happens in the start callback which is called
during probe.

Fixes: de520b8bd552 ("uwb: add HWA radio controller driver")
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@xxxxxxxxx>
Cc: David Vrabel <david.vrabel@xxxxxxx>
Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
 drivers/uwb/hwa-rc.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/drivers/uwb/hwa-rc.c
+++ b/drivers/uwb/hwa-rc.c
@@ -823,6 +823,9 @@ static int hwarc_probe(struct usb_interf
 	struct hwarc *hwarc;
 	struct device *dev = &iface->dev;
 
+	if (iface->cur_altsetting->desc.bNumEndpoints < 1)
+		return -ENODEV;
+
 	result = -ENOMEM;
 	uwb_rc = uwb_rc_alloc();
 	if (uwb_rc == NULL) {


Patches currently in stable-queue which might be from johan@xxxxxxxxxx are

queue-4.9/usb-serial-option-add-quectel-uc15-uc20-ec21-and-ec25-modems.patch
queue-4.9/input-ims-pcu-validate-number-of-endpoints-before-using-them.patch
queue-4.9/usb-usbtmc-add-missing-endpoint-sanity-check.patch
queue-4.9/input-cm109-validate-number-of-endpoints-before-using-them.patch
queue-4.9/input-iforce-validate-number-of-endpoints-before-using-them.patch
queue-4.9/mmc-ushc-fix-null-deref-at-probe.patch
queue-4.9/input-kbtab-validate-number-of-endpoints-before-using-them.patch
queue-4.9/usb-usbtmc-fix-probe-error-path.patch
queue-4.9/input-sur40-validate-number-of-endpoints-before-using-them.patch
queue-4.9/uwb-i1480-dfu-fix-null-deref-at-probe.patch
queue-4.9/input-hanwang-validate-number-of-endpoints-before-using-them.patch
queue-4.9/usb-idmouse-fix-null-deref-at-probe.patch
queue-4.9/uwb-hwa-rc-fix-null-deref-at-probe.patch
queue-4.9/usb-lvtest-fix-null-deref-at-probe.patch
queue-4.9/input-yealink-validate-number-of-endpoints-before-using-them.patch
queue-4.9/usb-serial-qcserial-add-dell-dw5811e.patch
queue-4.9/usb-uss720-fix-null-deref-at-probe.patch
queue-4.9/usb-wusbcore-fix-null-deref-at-probe.patch



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]