On Wed, Mar 22, 2017 at 10:56:02AM -0700, Ankur Arora wrote: > >It is ok to do upload_pm_data() with delay i.e. after some other > >resume actions are done and possibly xen-acpi-processor is in > >running state ? > The state uploaded is ACPI P and C state from struct acpi_processor > which AFAICS is stable once inited so a delay would not lead to > invalid state. > The only concern would be the ACPI pCPU hotplug logic in > acpi_processor_add() which could add a new entry in > per_cpu(processors) but that also looks okay because either we > get a NULL or we get a pointer to an inited structure. > > As for the hypervisor -- that falls back to more limited state after > resume (because some of this state is thrown away at suspend) and so > uses that until it gets the uploaded PM state from the initial-domain. Patch looks good to me then. Reviewed-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx>