Re: v4.1.38-rt46 build: 1 failures 46 warnings (v4.1.38-rt46)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey Arnd-

On Fri, Mar 17, 2017 at 09:21:35PM +0100, Arnd Bergmann wrote:
> On Fri, Mar 10, 2017 at 8:54 PM, Build bot for Mark Brown
> <broonie@xxxxxxxxxx> wrote:
> 
> > -------------------------------------------------------------------------------
> > defconfigs with issues (other than build errors):
> >      36 warnings    3 mismatches  : arm64-allmodconfig
> >       4 warnings    0 mismatches  : arm-multi_v5_defconfig
> >       5 warnings    0 mismatches  : arm-multi_v7_defconfig
> >       3 warnings    0 mismatches  : x86_64-defconfig
> >      31 warnings    0 mismatches  : arm-allmodconfig
> >       2 warnings    0 mismatches  : arm64-defconfig
> 
> For some reason, neither kernelci.org nor broonie's built bot include
> the stable/v4.1.y
> tree, but we do get reports for v4.1-rt, which unlike v4.4-rt show a number of
> warnings. Sasha, are you interested in backporting the fixes for these so we can
> eventually get a clean build and spot regressions more easily? A lot of these
> are just patches to shut up harmless warnings, but some also address real bugs.

I can't speak for Sasha, but I'd certainly like to see the RT-specific
build warnings fixed, and have already began the process of doing so.

The 4.1.y powerpc build is actually broken for newer gccs.  The fix is
upstream as 1e407ee3b21f9 ("powerpc/ptrace: Fix out of bounds array
access warning").  There are other build warnings on other architectures
as well.  I've resent the patch last week to stable folks, but was
having mailer problems, so perhaps need to resend.

I'm also happy to hear that the 4.1-rt is getting build testing by the
build bot.  Is there any way I can be CC'd on build reports on this
branch?  Or, is the best way for me just to subscribe to the list?

[..]
> >         ../net/ipv6/ip6_offload.c:261:25: warning: 'sit_gro_receive' defined but not used [-Wunused-function]
> 
> Here, upstream commit fac8e0f57969 ("tunnels: Don't apply GRO to multiple
>  layers of encapsulation.") seems to have been incorrectly backported into
> v4.1.y commit 066b300e5be4.
>
> I have not analyzed why the function is now unused, but in the original patch
> it is used, unlike in the backport.

It looks like this patch fixes a bug in commit feec0cb3f20b8 ("ipv6:
gro: support sit protocol"), which didn't land until v4.4, so perhaps
this patch can just be dropped from 4.1.y.

[..]
> >         ../include/linux/spinlock.h:256:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 
> I could not immediately find this one.

I'm not sure if full logs are available somewhere, but the line above
this is probably of more interest.  For example:

	drivers/tty/serial/amba-pl011.c: In function 'pl011_console_write':
	include/linux/spinlock.h:256:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]

Which looks like perhaps gcc is confused about the conditional
locking/unlocking in this function.

   Julia

PS. Apologies if I've mangled my reply, I've been having mail issues w/
    vger recently, had to reconstruct Arnd's original email from an archive.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]