On Thu, 2017-03-02 at 05:24 +0000, Bart Van Assche wrote: > On Wed, 2017-03-01 at 21:21 -0800, Nicholas A. Bellinger wrote: > > To reiterate the importance of having bug-fixes, especially those > > intended for stable, always be leading other patches.. > > You should know that I can't group all bugfixes at the start of the series > because some of the bugfixes depend on patches that are not bugfixes. > That makes no sense. Either it's a bug-fix to existing upstream code, or it's not. This patch was not a bug-fix to upstream, because it detailed a scenario that doesn't existing in upstream. That is, a case where ib_isert or ib_srpt calls target_generic_free_cmd() with wait_for_tasks = true or a case where wait_for_tasks = false blocks.