On Mon, Feb 20, 2017 at 04:29:16PM +0200, Mika Kuoppala wrote: > Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes: > > > Defer actual enabling of RPS to the set rps routine, called upon > > enabling and so we only start RPS when all thresholds have been set. > > > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx> > > Cc: stable@xxxxxxxxxxxxxxx > > As discussed in irc, we will need a followup cleanup as the > function names deviate from the actual content. They do still enable rps, just via set_rps_thresholds. We could go further and move that to a common point, e.g. if (gen >= 9) gen9_setup_rps(); ... else gen6_setup_rps(); enable_rps(); -> (the current reset_rps dance, but use intel_set_rps). -Chris -- Chris Wilson, Intel Open Source Technology Centre