Re: [PATCH] Revert "i2c: designware: detect when dynamic tar update is possible"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 13, 2017 at 05:22:42PM +0000, De Marchi, Lucas wrote:
> On Mon, 2017-02-13 at 11:18 +0200, Jarkko Nikula wrote:
> > This reverts commit 63d0f0a6952a1a02bc4f116b7da7c7887e46efa3.
> > 
> > It caused a regression on platforms where I2C controller is synthesized
> > with dynamic TAR update disabled. Detection code is testing is bit
> > DW_IC_CON_10BITADDR_MASTER in register DW_IC_CON read-only but fails to
> > restore original value in case bit is read-write.
> > 
> > Instead of fixing this we revert the commit since it was preparation for
> > the commit 0317e6c0f1dc ("i2c: designware: do not disable adapter after
> > transfer") which was also reverted.
> > 
> > Reported-by: Shah Nehal-Bakulchandra <Nehal-bakulchandra.Shah@xxxxxxx>
> > Reported-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> > Cc: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
> > Cc: <stable@xxxxxxxxxxxxxxx> # v4.9+
> > Fixes: 63d0f0a6952a ("i2c: designware: detect when dynamic tar update is possible")
> > Signed-off-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
> 
> Acked-By: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>

Why do you base64 encode your mails? E.g. Patchwork can't collect your
tags this way. Yes, it could be fixed maybe, but still?

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]