From: Richard Weinberger <richard@xxxxxx> commit a00052a296e54205cf238c75bd98d17d5d02a6db upstream. Commit c83ed4c9dbb35 ("ubifs: Abort readdir upon error") broke overlayfs support because the fix exposed an internal error code to VFS. Reported-by: Peter Rosin <peda@xxxxxxxxxx> Tested-by: Peter Rosin <peda@xxxxxxxxxx> Reported-by: Ralph Sennhauser <ralph.sennhauser@xxxxxxxxx> Tested-by: Ralph Sennhauser <ralph.sennhauser@xxxxxxxxx> Fixes: c83ed4c9dbb35 ("ubifs: Abort readdir upon error") Signed-off-by: Richard Weinberger <richard@xxxxxx> Signed-off-by: Willy Tarreau <w@xxxxxx> --- fs/ubifs/dir.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c index 27b2c23..db364d4 100644 --- a/fs/ubifs/dir.c +++ b/fs/ubifs/dir.c @@ -473,6 +473,14 @@ out: if (err != -ENOENT) ubifs_err("cannot find next direntry, error %d", err); + else + /* + * -ENOENT is a non-fatal error in this context, the TNC uses + * it to indicate that the cursor moved past the current directory + * and readdir() has to stop. + */ + err = 0; + /* 2 is a special value indicating that there are no more direntries */ file->f_pos = 2; -- 2.8.0.rc2.1.gbe9624a -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html