RE: [PATCH 1/3] PM / devfreq: Fix available_governor sysfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> The devfreq using passive governor is not able to change the governor.
> So, the user can not change the governor through 'available_governor' sysfs
> entry. Also, the devfreq which don't use the passive governor is not able to
> change to 'passive' governor on the fly.

Another thoughts on the characteristics of 'passive' governor:

1. Should we prohibit moving from "others" to "passive"?
2. Should we show "passive" in the available list if it's not passive now?
3. Why don't we show anyway and reject it when actually tries to change?
4. Or should we add a value in devfreq struct that is confired at devfreq
device add, which prohibits changing governors? (and passive will
return error if that flag is not set or it will set the value automatically)

Cheers,
MyungJoo

> 
> Fixes: 996133119f57 ("PM / devfreq: Add new passive governor")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> ---
>  drivers/devfreq/devfreq.c | 34 +++++++++++++++++++++++++++++++++-
>  1 file changed, 33 insertions(+), 1 deletion(-)

[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]